Re: [PATCH 1/1] time: clocksource: use setup_timer() helper.

[Thomas Gleixner]

On Thu, 21 Sep 2017, Allen Pais wrote:

>     Use setup_timer function instead of initializing timer with the
>     function and data fields.
> 
> Signed-off-by: Allen Pais <allen.lkml@xxxxxxxxx>
> ---
>  kernel/time/clocksource.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 03918a1..5b51d5b 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -290,8 +290,7 @@ static inline void clocksource_start_watchdog(void)
>  {
>  	if (watchdog_running || !watchdog || list_empty(&watchdog_list))
>  		return;
> -	init_timer(&watchdog_timer);
> -	watchdog_timer.function = clocksource_watchdog;
> +	setup_timer(&watchdog_timer, clocksource_watchdog, 0UL);

We changed this to use the timer_setup() function. Please resend.

Thanks,

	tglx