Re: [PATCH v2 net-next 1/2] net: dsa: lan9303: Add port_fast_age and port_fdb_dump methods

[Egil Hjelmeland]

On 19. okt. 2017 17:12, Vivien Didelot wrote:
> Hi Egil,
>
> Egil Hjelmeland <privat@xxxxxxxxxxxxxxxxxx> writes:
>
> > > Why is there different spacing and prefix with these defines?
> >
> > The extra space is to set bit definitions apart from register offsets,
> > a convention that is used in the file. However, agree that the
> > bit defs should be prefixed with LAN9303_ to be consistent with
> > rest of the file.
>
> OK, I'm fine with this spacing then. The prefix would be nice though,
> thanks!
Prefix already done in my working version.

> If you cannot think about a comment text which brings value, it
> certainly means it isn't necessary. As you said the implicit "alr"
> namespace already helps here. I'd personally drop all section comments
> ;-)

Then I will just drop the section comments.

> Thank you,
>
>        Vivien

Egil