Re: [PATCH v10 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

From: Pali RohÃr
Date: Thu Oct 19 2017 - 14:06:10 EST


On Thursday 19 October 2017 12:50:08 Mario Limonciello wrote:
> + priv->interface_version = buffer[2];
> + priv->size = buffer[3];
> + ret = 0;
> + dev_set_drvdata(&wdev->dev, priv);
> + list_add_tail(&priv->list, &wmi_list);

Still missing lock when changing wmi_list.

> +
> + dev_dbg(&wdev->dev, "Detected Dell WMI interface version %lu and buffer size %lu\n",
> + (unsigned long) priv->interface_version,
> + (unsigned long) priv->size);
> +
> +out:
> + kfree(obj);
> + return ret;
> +}

--
Pali RohÃr
pali.rohar@xxxxxxxxx