RE: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

[Long Li]

> On Tue, Oct 17, 2017 at 01:35:21PM -0400, Cathy Avery wrote:
> > +	/*
> > +	 * Set the error handler work queue.
> > +	 */
> > +	snprintf(host_dev->work_q_name, sizeof(host_dev-
> >work_q_name),
> > +		 "storvsc_error_wq_%d", host->host_no);
> > +	host_dev->handle_error_wq =
> > +			create_singlethread_workqueue(host_dev-
> >work_q_name);
> 
> If you use alloc_ordered_workqueue directly instead of
> create_singlethread_workqueue you can pass a format string and don't need
> the separate allocation.
> 
> But I'm not sure if Tejun is fine with using __WQ_LEGACY directly..
> 
> Except for this nit this looks fine to me:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

The work storvsc_host_scan (scheduled from function storvsc_on_receive) should also use this workqueue. We can do it in another patch.

Reviewed-by: Long Li <longli@xxxxxxxxxxxxx>

> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdriverd
> ev.linuxdriverproject.org%2Fmailman%2Flistinfo%2Fdriverdev-
> devel&data=02%7C01%7Clongli%40microsoft.com%7C9c303c3630ef490cecc3
> 08d5170702a2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636440
> 241242573253&sdata=tbCBOnKxtRR38rAdsBDa7zA0Jc2XwrySTsH3uyRxHxA%
> 3D&reserved=0