Re: [PATCH v9 13/29] x86/insn-eval: Add utility functions to get segment selector

From: Borislav Petkov
Date: Fri Oct 20 2017 - 03:56:00 EST


On Wed, Oct 18, 2017 at 11:30:54PM -0700, Ricardo Neri wrote:
> I saw that Documentation/process/email-clients.rst that emailed patches
> should be in ASCII or UTF-8 encodings only, but my patch in UTF-8
> causes problems. Then is UTF-8 not desirable?

Well, I don't think so even though I couldn't find anything that says so
explicitly.

But I *think* source files' encoding should be ASCII, as otherwise even
the tool patch barfs:

patch: **** malformed patch at line 124:

> Thanks for the detailed explanation and the pointers to fix the problem.
> I am sorry for the inconvenience. Here is the patch again. I made sure
> that it applies cleanly with git am and patch:

Yes, it looks good now:

Reviewed-by: Borislav Petkov <bp@xxxxxxx>

( ... or I've been staring definitely too long at this code and don't care
anymore :-)))

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--