Re: [PATCH 1/2] serdev: ttyport: enforce tty-driver open() requirement

From: Greg Kroah-Hartman
Date: Fri Oct 20 2017 - 08:21:41 EST


On Tue, Oct 17, 2017 at 11:07:20AM -0500, Rob Herring wrote:
> On Mon, Oct 16, 2017 at 8:06 AM, Johan Hovold <johan@xxxxxxxxxx> wrote:
> > The tty-driver open routine is mandatory, but the serdev
> > tty-port-controller implementation did not treat it as such and would
> > instead fall back to calling tty_port_open() directly.
>
> The idea was to eventually get rid of the tty_struct dependency and
> only depend on tty_port. That's very invasive though and needs various
> pieces of tty_struct to move into tty_port.
>
> Of course, tty_port_open itself would have to change as well, so this
> change doesn't really matter.

So are you acking these patches?

confused,

greg k-h