Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers

[gregkh@xxxxxxxxxxxxxxxxxxx]

On Fri, Oct 06, 2017 at 07:57:00AM -0700, Stephen Hemminger wrote:
> On Fri, 6 Oct 2017 13:50:44 +0000
> "Stahl, Manuel" <manuel.stahl@xxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > MSI(X) interrupts are not shared between devices. So when available
> > those should be preferred over legacy interrupts.
> > 
> > Signed-off-by: Manuel Stahl <manuel.stahl@xxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/uio/uio_pci_dmem_genirq.c | 27 ++++++++++++++++++++-------
> >  drivers/uio/uio_pci_generic.c     | 24 ++++++++++++++++++------
> >  2 files changed, 38 insertions(+), 13 deletions(-)
> 
> The last time I tried to do MSI-X with pci-generic it got rejected
> by the maintainer.

Hm, yeah, this would break users today that do not have msi-x, right?

Not good, Manuel, how well did you test this?

thanks,

greg k-h