Re: [PATCH 02/12] nvmem: mtk-efuse: use stack for nvmem_config instead of malloc'ing it

[Masahiro Yamada]

2017-10-20 22:34 GMT+09:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
> On Mon, Oct 09, 2017 at 03:26:31PM +0200, srinivas.kandagatla@xxxxxxxxxx wrote:
>> From: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>
>> nvmem_register() copies all the members of nvmem_config to
>> nvmem_device.  So, nvmem_config is one-time use data during
>> probing.  There is no point to keep it until the driver detach.
>> Using stack should be no problem because nvmem_config is pretty
>> small.
>
> Same objection as previous patch, what is wrong with it as-is?
>

It is wasting memory.


-- 
Best Regards
Masahiro Yamada