Re: [PATCH v9 19/29] x86/insn-eval: Add support to resolve 32-bit address encodings
From: Borislav Petkov
Date: Fri Oct 20 2017 - 14:38:43 EST
On Fri, Oct 20, 2017 at 11:24:48AM -0700, Ricardo Neri wrote:
> I will create these helper functions. This change and your suggestion in
> patch 18 will impact other patches in the series (e.g., the function
> get_addr_ref_16() in patch 22). Would it make sense to submit a v10 and
> resume review there?
>
> Also, do you think I am still on-time to make it to v4.15?
Well, I've been thinking about it: handling huge patchsets is always
very cumbersome, time-consuming and error prone. So perhaps it would be
easier - maybe - I'm not saying it will definitely but only maybe - if
you would split the patchset into, say, two, pieces, or halves, if you
will.
And I think the first piece is more or less reviewed and if tip guys
don't find any booboos, it could go in now. Which would free you to deal
with the other half later.
Anyway, this is just an idea - it might not work but it is still worth
considering.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--