Re: [PATCH net] hv_sock: add locking in the open/close/release code paths

From: David Miller
Date: Fri Oct 20 2017 - 21:21:42 EST


From: Dexuan Cui <decui@xxxxxxxxxxxxx>
Date: Thu, 19 Oct 2017 03:33:14 +0000

>
> Without the patch, when hvs_open_connection() hasn't completely established
> a connection (e.g. it has changed sk->sk_state to SS_CONNECTED, but hasn't
> inserted the sock into the connected queue), vsock_stream_connect() may see
> the sk_state change and return the connection to the userspace, and next
> when the userspace closes the connection quickly, hvs_release() may not see
> the connection in the connected queue; finally hvs_open_connection()
> inserts the connection into the queue, but we won't be able to purge the
> connection for ever.
>
> Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx>

Applied.