Re: [PATCH 11/14] soundwire: cdns: Add cadence module

[Mark Brown]

On Thu, Oct 19, 2017 at 08:33:27AM +0530, Vinod Koul wrote:

> Cadence IP implements SoundWire Master. Add base cadence module
> initialization and interrupt handling

It's probably worth saying something about how this isn't a device
driver but rather a library for device drivers.

> +	if (int_status & CDNS_MCP_INT_CTRL_CLASH) {
> +
> +		/* Slave is driving bit slot during control word */
> +		dev_err_ratelimited(cdns->dev, "Bus clash for control word\n");
> +		int_status |= CDNS_MCP_INT_CTRL_CLASH;
> +	}

So with this (and the other error flags) we check to see if the bit is
set, print an error and then set the bit we were looking for in the same
variable we just checked?

Attachment: signature.asc
Description: PGP signature