Re: [PATCH 02/14] soundwire: Add SoundWire bus type

[Vinod Koul]

On Sat, Oct 21, 2017 at 10:03:48AM +0100, Mark Brown wrote:
> On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote:
> 
> > +	ret = dev_pm_domain_attach(dev, false);
> > +	if (ret) {
> > +		dev_err(dev, "Failed to attach PM domain: %d\n", ret);
> > +		return ret;
> > +	}
> > +
> > +	ret = drv->probe(slave, id);
> > +	if (ret) {
> > +		dev_err(dev, "Probe of %s failed: %d\n", drv->name, ret);
> > +		return ret;
> > +	}
> 
> We don't detach the power domain if the probe fails.

we should, thanks for spotting

-- 
~Vinod