Re: [PATCH v4 2/2] dma: sprd: Add Spreadtrum DMA driver

[Baolin Wang]

Hi Vinod,

On 10 October 2017 at 13:23, Baolin Wang <baolin.wang@xxxxxxxxxxxxxx> wrote:
> This patch adds the DMA controller driver for Spreadtrum SC9860 platform.
>
> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxx>
> ---
> Changes since v3:
>  - Remove redundant local 'mask' and 'val' variables.
>  - Simplify sprd_dma_get_req_type() function.
>  - Change pm_runtime_put_sync() to pm_runtime_put() in probe function.
>  - Simplify sizeof function.
>  - Other coding style fixes.
>
> Changes since v2:
>  - Add COMPILE_TEST as dependency.
>  - Renamed DMA macro definition properly.
>  - Add sprd_dma_chn_update() helpers to save lots of code.
>  - Change pm_runtime_put_sync() to pm_runtime_put() when free resources.
>  - Re-implement the sprd_dma_tx_status() function.
>  - Free irq and kill tasklet when remove driver.
>  - Add some documentaion.
>  - Change to module_init() level and add MODULE_ALIAS().
>  - Other coding style fixes.
>
> Changes since v1:
>  - Use virt-dma to manage dma descriptors.
>  - Remove link-list and channel-start-channel Spreadtrum special features.
>  - Remove device_config implementation.
>  - Other optimization.
>
> Note: This patch just implemented the basic DMA_MEMCPY function, and in
> future we will send new patches to introduce some Speadtrum special features,
> that will be talk about how to handle these features easily instead of in one
> big patch which is hard to review.
> ---

Do you have any comments for this version patchset? If not, could you
apply this patchset into your branch? Thanks.

-- 
Baolin.wang
Best Regards