Re: [PATCH V3] selftests/vm: Add tests validating mremap mirror functionality

[Anshuman Khandual]

On 10/20/2017 04:54 AM, Mike Kravetz wrote:
> On 10/17/2017 10:55 PM, Anshuman Khandual wrote:
>> This adds two tests to validate mirror functionality with mremap()
>> system call on shared and private anon mappings. After the commit
>> dba58d3b8c5 ("mm/mremap: fail map duplication attempts for private
>> mappings"), any attempt to mirror private anon mapping will fail.
>>
>> Suggested-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
>> Signed-off-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
> The tests themselves look fine.  However, they are pretty simple and
> could very easily be combined into one 'mremap_mirror.c' file.  I
> would prefer that they be combined, but it is not a deal breaker.
> 
> Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
> 

Hello Andrew/Shuah,

Is this okay or should I resend this patch with both tests folded
into one test case file ?

- Anshuman