Re: [PATCH v2] dwc: dra7xx: Print link state to console for debug

[Faiz Abbas]

Hi Bjorn,

On Saturday 21 October 2017 04:39 AM, Bjorn Helgaas wrote:
> On Thu, Oct 19, 2017 at 06:13:29PM +0530, Faiz Abbas wrote:
>> Enable support for printing the LTSSM link state for debugging PCI
>> when link is down.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@xxxxxx>
>> ---
>> v2:
>>  1. Changed dev_err() to dev_dbg()
>>  2. Changed static char array to static const char * const
>>  3. format changes
> 
> I'm not really sure how much debug help we want to carry around in the
> mainline kernel.  End users aren't going to use this; it seems like
> more of a lab tool, and in situations like that you usually end up
> carrying around some out-of-tree patches for a while anyway.  But I
> can probably be convinced either way.
> 

It'll be easier to support customers if they can tell us what the state
of the link is by just changing the log level. We won't have to send a
debug patch to the customer to find that out.

Thanks,
Faiz