Re: [PATCH v2 14/17] phy: qcom-qusb2: Set vbus sw-override signal in device mode

[Manu Gautam]

Hi Kishon,

Please review this so that I can re-submit patch-set based on this approach.

On 10/9/2017 1:33 PM, Manu Gautam wrote:
> Hi Kishon
>
> On 10/5/2017 2:38 PM, Manu Gautam wrote:
>> Kishon,
>> What would you suggest here?
>> Should we add new calls e.g. phy_get/set_current_speed like::
>>
>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
>> index 78bb0d7..41d9ec2 100644
>> --- a/include/linux/phy/phy.h
>> +++ b/include/linux/phy/phy.h
>> @@ -29,6 +29,14 @@ enum phy_mode {
>> ÂÂÂÂÂÂÂ PHY_MODE_USB_OTG,
>> Â};
>>
>> +enum phy_speed {
>> +ÂÂÂÂÂÂ PHY_SPEED_INVALID,
>> +ÂÂÂÂÂÂ PHY_SPEED_USB_LS,
>> +ÂÂÂÂÂÂ PHY_SPEED_USB_FS_HS,
>> +ÂÂÂÂÂÂ PHY_SPEED_USB_SS,
>> +};
>> +
>> Â/**
>> Â * struct phy_ops - set of function pointers for performing phy operations
>> Â * @init: operation to be performed for initializing phy
>> @@ -45,6 +53,7 @@ struct phy_ops {
>> ÂÂÂÂÂÂÂ intÂÂÂÂ (*power_on)(struct phy *phy);
>> ÂÂÂÂÂÂÂ intÂÂÂÂ (*power_off)(struct phy *phy);
>> ÂÂÂÂÂÂÂ intÂÂÂÂ (*set_mode)(struct phy *phy, enum phy_mode mode);
>> +ÂÂÂÂÂÂ intÂÂÂÂ (*set_speed)(struct phy *phy, enum phy_speed speed);
>> ÂÂÂÂÂÂÂ intÂÂÂÂ (*reset)(struct phy *phy);
>> ÂÂÂÂÂÂÂ struct module *owner;
>> Â};
>>
> @Kishon,
> Let me know if we can add set_speed to phy_ops. We need this for glue
> driver to notify PHY of current connection speed to enable appropriate
> wakeup interrupts.
>
>

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project