Re: [RFC v6 8/9] platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls
From: Lee Jones
Date: Mon Oct 23 2017 - 11:46:06 EST
On Wed, 18 Oct 2017, sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
>
> Removed redundant IPC helper functions and refactored the driver to use
> generic IPC device driver APIs. Also, cleaned up the driver to minimize
> the usage of global variable ipcdev by propogating the struct
> intel_pmc_ipc_dev pointer or by getting it from device private data.
>
> This patch also cleans-up PMC IPC user drivers(intel_telemetry_pltdrv.c,
> intel_soc_pmic_bxtwc.c) to use APIs provided by generic IPC driver.
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> ---
> arch/x86/include/asm/intel_pmc_ipc.h | 31 +-
> drivers/mfd/intel_soc_pmic_bxtwc.c | 37 ++-
> drivers/platform/x86/intel_pmc_ipc.c | 393 ++++++++++----------------
> drivers/platform/x86/intel_telemetry_pltdrv.c | 128 ++++-----
> include/linux/mfd/intel_soc_pmic.h | 2 +
Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog