Re: [PATCH V3 4/6] perf tools: add perf_data_file__open_tmp

[Jiri Olsa]

On Mon, Oct 23, 2017 at 04:19:19PM +0000, Liang, Kan wrote:

SNIP

> > >  ssize_t perf_data_file__write(struct perf_data_file *file, diff --git
> > > a/tools/perf/util/data.h b/tools/perf/util/data.h index
> > > ae510ce..892b3d5 100644
> > > --- a/tools/perf/util/data.h
> > > +++ b/tools/perf/util/data.h
> > > @@ -10,6 +10,7 @@ enum perf_data_mode {
> > >
> > >  struct perf_data_file {
> > >  	const char		*path;
> > > +	char			*tmp_path;
> > 
> > could we add is_tmp instead of new path pointer and keep the path for the
> > name..?
> 
> The 'path' is const char. I think it's not good for tmp file which
> generate the file name in real time.

then change path to 'char *' ? I just dont think having
2 name pointers for path will keep this simple

jirka