Re: [PATCH v8 3/5] platform: Add driver for RAVE Supervisory Processor

[Andrey Smirnov]

On Sat, Oct 21, 2017 at 10:17 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> On 10/18/2017 10:01 AM, Andrey Smirnov wrote:
>>
>> Add a driver for RAVE Supervisory Processor, an MCU implementing
>> varoius bits of housekeeping functionality (watchdoging, backlight
>
>
> various
>
>> control, LED control, etc) on RAVE family of products by Zodiac
>> Inflight Innovations.
>>
>> This driver implementes core MFD/serdev device as well as
>> communication subroutines necessary for commanding the device.
>>
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Cc: cphealy@xxxxxxxxx
>> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>> Cc: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx>
>> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> Cc: Pavel Machek <pavel@xxxxxx>
>> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
>> Cc: Rob Herring <robh@xxxxxxxxxx>
>> Cc: Johan Hovold <johan@xxxxxxxxxx>
>> Tested-by: Chris Healy <cphealy@xxxxxxxxx>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
>
>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>
> [question below]
>
>
>> ---
>>   drivers/platform/Kconfig        |   2 +
>>   drivers/platform/Makefile       |   1 +
>>   drivers/platform/rave/Kconfig   |  25 ++
>>   drivers/platform/rave/Makefile  |   1 +
>>   drivers/platform/rave/rave-sp.c | 670
>> ++++++++++++++++++++++++++++++++++++++++
>>   include/linux/rave-sp.h         |  54 ++++
>>   6 files changed, 753 insertions(+)
>>   create mode 100644 drivers/platform/rave/Kconfig
>>   create mode 100644 drivers/platform/rave/Makefile
>>   create mode 100644 drivers/platform/rave/rave-sp.c
>>   create mode 100644 include/linux/rave-sp.h
>>
>> diff --git a/drivers/platform/Kconfig b/drivers/platform/Kconfig
>> index c11db8bceea1..e6db685bb895 100644
>> --- a/drivers/platform/Kconfig
>> +++ b/drivers/platform/Kconfig
>> @@ -8,3 +8,5 @@ endif
>>   source "drivers/platform/goldfish/Kconfig"
>>     source "drivers/platform/chrome/Kconfig"
>> +
>> +source "drivers/platform/rave/Kconfig"
>> diff --git a/drivers/platform/Makefile b/drivers/platform/Makefile
>> index ca2692510733..17bdec5ece0c 100644
>> --- a/drivers/platform/Makefile
>> +++ b/drivers/platform/Makefile
>> @@ -7,3 +7,4 @@ obj-$(CONFIG_MIPS)              += mips/
>>   obj-$(CONFIG_OLPC)            += olpc/
>>   obj-$(CONFIG_GOLDFISH)                += goldfish/
>>   obj-$(CONFIG_CHROME_PLATFORMS)        += chrome/
>> +obj-y += rave/
>> diff --git a/drivers/platform/rave/Kconfig b/drivers/platform/rave/Kconfig
>> new file mode 100644
>> index 000000000000..c0964a531991
>> --- /dev/null
>> +++ b/drivers/platform/rave/Kconfig
>> @@ -0,0 +1,25 @@
>> +#
>> +# Platform support for Zodiac RAVE hardware
>> +#
>> +
>> +menuconfig RAVE_PLATFORMS
>> +       bool "Platform support for Zodiac RAVE hardware"
>> +       help
>> +         Say Y here to get to see options for platform support for
>> +         various devices present in RAVE hardware. This option alone
>> +         does not add any kernel code.
>> +
>> +         If you say N, all options in this submenu will be skipped
>> +         and disabled.
>> +
>> +if RAVE_PLATFORMS
>> +
>> +config RAVE_SP_CORE
>> +       tristate "RAVE SP MCU core driver"
>> +       depends on SERIAL_DEV_BUS
>> +       select CRC_CCITT
>> +       help
>> +         Select this to get support for the Supervisory Processor
>> +         device found on several devices in RAVE line of hardware.
>> +
>
>
> Are there going to be more entries in this menu ?

Now that you mention it, I don't think so, since all of the MFD cell
devices belong to existing subsystems (watchdog, nvmem, hwmon, leds,
input). Should I just convert it to additional variable for "depends"
instead?

Thanks,
Andrey Smirnov