Re: [PATCH 2/2] perf, tools, record: Fix -c/-F options for cpu event aliases

[Jiri Olsa]

On Fri, Oct 20, 2017 at 01:27:55PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> 
> The Intel PMU event aliases have a implicit
> period= specifier to set the default period.
> 
> Unfortunately this breaks overriding these periods with -c or
> -F, because the alias terms look like they are user specified
> to the internal parser, and user specified event qualifiers override
> the command line options.
> 
> Track that they are coming from aliases by adding a
> "weak" state to the term. Any weak terms don't override
> command line options.
> 
> I only did it for -c/-F for now, I think that's the
> only case that's broken currently.
> 
> Before:
> 
> $ perf record -c 1000 -vv -e uops_issued.any
> ...
>   { sample_period, sample_freq }   2000003
> 
> After:
> 
> $ perf record -c 1000 -vv -e uops_issued.any
> ...
>   { sample_period, sample_freq }   1000
> 
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka