Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]

[Jani Nikula]

On Mon, 23 Oct 2017, David Binderman <dcb314@xxxxxxxxxxx> wrote:
> Hello there,
>
> Source code is
>
>         if ((temp & PIPEACONF_PIPE_STATE) == 1)
>             break;
>
> but
>
> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE		(1 << 30)
> $ 
>
> Suggest new code
>
>         if ((temp & PIPEACONF_PIPE_STATE) != 0)
>             break;

Suggest looking at latest sources. ;)

Fixed by 67a3b63a54cb ("drm: gma500: fix logic error").

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center