Re: [PATCH] tpm_tis_core: Use common error handling code in tpm_tis_send_data()

From: Jarkko Sakkinen
Date: Tue Oct 24 2017 - 09:55:26 EST


On Mon, Oct 23, 2017 at 03:51:09PM +0200, SF Markus Elfring wrote:
> >> @@ -315,6 +311,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len)
> >>
> >> return 0;
> >>
> >> +report_timeout:
> >> + rc = -ETIME;
> >> out_err:
> >> tpm_tis_ready(chip);
> >> return rc;
> >> --
> >> 2.14.2
> >>
> >
> > NAK. wait_for_tpm_stat() should give that error code.
>
> This is a pity that you reject another bit of code reduction.
>
> Regards,
> Markus

It is a pity that you continue doing this constant patch trolling.
That is what it is.

/Jarkko.