Re: [PATCH v5 11/13] xen/pvcalls: implement poll command

[Boris Ostrovsky]

On 10/23/2017 07:06 PM, Stefano Stabellini wrote:
> On Tue, 17 Oct 2017, Boris Ostrovsky wrote:
>>> +static unsigned int pvcalls_front_poll_passive(struct file *file,
>>> +					       struct pvcalls_bedata *bedata,
>>> +					       struct sock_mapping *map,
>>> +					       poll_table *wait)
>>> +{
>>> +	int notify, req_id, ret;
>>> +	struct xen_pvcalls_request *req;
>>> +
>>> +	if (test_bit(PVCALLS_FLAG_ACCEPT_INFLIGHT,
>>> +		     (void *)&map->passive.flags)) {
>>> +		uint32_t req_id = READ_ONCE(map->passive.inflight_req_id);
>>> +
>>> +		if (req_id != PVCALLS_INVALID_ID &&
>>> +		    READ_ONCE(bedata->rsp[req_id].req_id) == req_id)
>>> +			return POLLIN | POLLRDNORM;
>>
>> Same READ_ONCE() question as for an earlier patch.
> Same answer :-)


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

>
>
>>> +
>>> +		poll_wait(file, &map->passive.inflight_accept_req, wait);
>>> +		return 0;
>>> +	}
>>> +