Re: [PATCH] rds: Fix uninitialized variable

From: HÃkon Bugge
Date: Tue Oct 24 2017 - 12:16:37 EST


Ignore this, sent the old one.

HÃkon

> On 24 Oct 2017, at 18:07, HÃkon Bugge <Haakon.Bugge@xxxxxxxxxx> wrote:
>
> send_flags needs to be initialized before calling
> rds_ib_set_wr_signal_state().
>
> Signed-off-by: HÃkon Bugge <haakon.bugge@xxxxxxxxxx>
> ---
> net/rds/ib_send.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
> index 6ab39db..8f46755 100644
> --- a/net/rds/ib_send.c
> +++ b/net/rds/ib_send.c
> @@ -792,6 +792,7 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
> send->s_atomic_wr.compare_add_mask = op->op_m_fadd.nocarry_mask;
> send->s_atomic_wr.swap_mask = 0;
> }
> + send->s_wr.send_flags = 0;
> nr_sig = rds_ib_set_wr_signal_state(ic, send, op->op_notify);
> send->s_atomic_wr.wr.num_sge = 1;
> send->s_atomic_wr.wr.next = NULL;
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html