Re: [PATCH 0/9] Assorted cleanups for staging/.../lustre/ldlm/ldlm_flock.c

From: James Simmons
Date: Tue Oct 24 2017 - 18:20:50 EST



> This file contains quite a bit of dead code and unused variables.
> This patch series cleans it up in various ways.
> It should change behaviour at all, just code
> readability/maintainabilty.
>
> I sent the back in July but got not response, possibly because there
> were included with other patches which caused a distraction.
> So here they are by themselves.

Thanks for separating them out. I will give them a spin.

> Thanks,
> NeilBrown
>
>
> ---
>
> NeilBrown (9):
> staging: lustre: ldlm: remove 'first_enq' arg from ldlm_process_flock_lock()
> staging: lustre: ldlm: remove unused 'work_list' arg from ldlm_process_flock_lock()
> staging: lustre: ldlm: remove unneeded 'err' arg to ldlm_process_flock_lock()
> staging: lustre: ldlm: remove 'flags' arg from ldlm_process_flock_lock()
> staging: lustre: ldlm: remove unused 'overlaps' variable
> staging: lustre: ldlm: remove 'flags' arg from ldlm_flock_destroy()
> staging: lustre: ldlm: tidy list walking in ldlm_flock()
> staging: lustre: ldlm: remove unnecessary 'ownlocks' variable.
> staging: lustre: ldlm: remove unused field 'fwd_generation'
>
>
> drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 208 +++++------------------
> 1 file changed, 42 insertions(+), 166 deletions(-)
>
> --
> Signature
>
>