Re: [PATCH] spi-nor: intel-spi: Remove EXPERT dependency

From: Cyrille Pitchen
Date: Tue Oct 24 2017 - 18:25:46 EST


Le 24/10/2017 Ã 09:40, Bin Meng a ÃcritÂ:
> The idea to have the intel-spi driver dependent on EXPERT was exactly
> because we did not want ordinary users playing with the device and
> inadvertently overwrite their BIOSes (if it is not protected). This
> seems to be superfluous hence remove it.
>
> Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Bin Meng <bmeng.cn@xxxxxxxxx>

Applied to the spi-nor/next branch of l2-mtd (reworked a little bit
since the original patch depends on "spi-nor: intel-spi: Fix Kconfig
dependency to LPC_ICH", see below).

Thanks!
> ---
>
> drivers/mtd/spi-nor/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index abf453a..be7cfb9 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -90,7 +90,7 @@ config SPI_INTEL_SPI
> tristate
>
> config SPI_INTEL_SPI_PCI
> - tristate "Intel PCH/PCU SPI flash PCI driver" if EXPERT
> + tristate "Intel PCH/PCU SPI flash PCI driver"
> depends on X86 && PCI
> select SPI_INTEL_SPI
> help
> @@ -106,7 +106,7 @@ config SPI_INTEL_SPI_PCI
> will be called intel-spi-pci.
>
> config SPI_INTEL_SPI_PLATFORM
> - tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
> + tristate "Intel PCH/PCU SPI flash platform driver"
> depends on X86 && PCI
removed " && PCI"
> select SPI_INTEL_SPI
> select LPC_ICH
removed "select LPC_ICH"
>