Re: hwmon/amc6821: Use common error handling code in amc6821_init_client()

From: SF Markus Elfring
Date: Wed Oct 25 2017 - 02:05:17 EST

Next message: Matthew Giassa: "[PATCH] staging: wlan-ng: resolve sparse endianness error."
Previous message: Dan Carpenter: "Re: [PATCH 2/2] drm/rcar-du: Adjust 14 checks for null pointers"
In reply to: Guenter Roeck: "Re: [PATCH] hwmon/amc6821: Use common error handling code in amc6821_init_client()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> Nack; I am not a friend of that much verboseness to start with,
> and I don't think the patch improves readability.

* Do you care to avoid code duplication for two error messages in this use case?

* How do you think about to return a single error code directly
without using an intermediate variable?

Regards,
Markus

Next message: Matthew Giassa: "[PATCH] staging: wlan-ng: resolve sparse endianness error."
Previous message: Dan Carpenter: "Re: [PATCH 2/2] drm/rcar-du: Adjust 14 checks for null pointers"
In reply to: Guenter Roeck: "Re: [PATCH] hwmon/amc6821: Use common error handling code in amc6821_init_client()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]