Re: Proposal: rename tpm1_eventlog.c and tpm2_eventlog.c

[Thiebaud Weksteen]

On Wed, Oct 25, 2017 at 12:21 AM, Jarkko Sakkinen
<jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote:
> I noticed when making slides for KS that the naming for event log stuff
> that the naming is so broken that it is hard to understand the code.
> Here it really would make sense to have a patch set just to clean up the
> cruft.

Agreed and happy to help.

>
> Random examples of more senseful naming:
>
> * tpm2_bios_measurements_start() should be rather something like
>   tpm_eventlog_seq_agile_start().
> * tpm_bios_measurements_start() should be rather something like
>   tpm_eventlog_seq_sha1_start().
>
> Corresponding structs would be tpm_eventlog_agile_seq_ops and
> tpm_eventlog_sha1_seq_ops.
>
> Finally, I would place the file operations, being so complicated, in
> separate files:
>
> * tpm_eventlog_seq_sha1.c
> * tpm_eventlog_seq_eventlog.c

I assume you meant tpm_eventlog_seq_agile.c ?

>
> And move all the management code that is right now illogically located
> in tpm1_eventlog.c to tpm_eventlog.c that would be the entry point for
> the event log.
>
> The code is laid out so badly right now that I have really hard time
> understanding it if I haven't looked at it within last couple of weeks.
> It's really a trainwreck at the moment. We must clean up it up fast.
>
> Getting this done will help me to review patches to this area faster
> so it would be a benefit for everyone. The current structure makes every
> event log patch a pain to review.

Since this may conflict with the last patch set I sent, are you happy
for me to base this new set on tpmdd/master?

>
> /Jarkko