[tip:locking/core] locking/lockdep, sched/completions: Change the prefix of lock name for completion variables
From: tip-bot for Byungchul Park
Date: Wed Oct 25 2017 - 07:15:05 EST
Commit-ID: 24208435e343679b21502fb90786084dfaf15369
Gitweb: https://git.kernel.org/tip/24208435e343679b21502fb90786084dfaf15369
Author: Byungchul Park <byungchul.park@xxxxxxx>
AuthorDate: Wed, 25 Oct 2017 17:55:59 +0900
Committer: Ingo Molnar <mingo@xxxxxxxxxx>
CommitDate: Wed, 25 Oct 2017 12:19:00 +0200
locking/lockdep, sched/completions: Change the prefix of lock name for completion variables
CONFIG_LOCKDEP_COMPLETIONS uses "(complete)" as a prefix of lock name
for completion variable.
However, what we should use here is a noun - so use "(completion)" instead.
Suggested-by: Ingo Molnar <mingo@xxxxxxxxxx>
Signed-off-by: Byungchul Park <byungchul.park@xxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: amir73il@xxxxxxxxx
Cc: axboe@xxxxxxxxx
Cc: darrick.wong@xxxxxxxxxx
Cc: david@xxxxxxxxxxxxx
Cc: hch@xxxxxxxxxxxxx
Cc: idryomov@xxxxxxxxx
Cc: johan@xxxxxxxxxx
Cc: johannes.berg@xxxxxxxxx
Cc: kernel-team@xxxxxxx
Cc: linux-block@xxxxxxxxxxxxxxx
Cc: linux-fsdevel@xxxxxxxxxxxxxxx
Cc: linux-mm@xxxxxxxxx
Cc: linux-xfs@xxxxxxxxxxxxxxx
Cc: oleg@xxxxxxxxxx
Cc: tj@xxxxxxxxxx
Link: http://lkml.kernel.org/r/1508921765-15396-4-git-send-email-byungchul.park@xxxxxxx
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
---
include/linux/completion.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/completion.h b/include/linux/completion.h
index cae5400..9121803 100644
--- a/include/linux/completion.h
+++ b/include/linux/completion.h
@@ -53,7 +53,7 @@ static inline void complete_release_commit(struct completion *x)
do { \
static struct lock_class_key __key; \
lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \
- "(complete)" #x, \
+ "(completion)" #x, \
&__key, 0); \
__init_completion(x); \
} while (0)
@@ -67,7 +67,7 @@ static inline void complete_release_commit(struct completion *x) {}
#ifdef CONFIG_LOCKDEP_COMPLETIONS
#define COMPLETION_INITIALIZER(work) \
{ 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait), \
- STATIC_CROSS_LOCKDEP_MAP_INIT("(complete)" #work, &(work)) }
+ STATIC_CROSS_LOCKDEP_MAP_INIT("(completion)" #work, &(work)) }
#else
#define COMPLETION_INITIALIZER(work) \
{ 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait) }