Re: [RFC 10/14] bootsplash: Add animation support

From: Max Staudt
Date: Wed Oct 25 2017 - 13:23:20 EST


On 10/25/2017 07:20 PM, Randy Dunlap wrote:
> On 10/25/17 05:45, Max Staudt wrote:
>> @@ -117,17 +128,45 @@ static bool is_fb_compatible(struct fb_info *info)
>> */
>> void bootsplash_render_full(struct fb_info *info)
>> {
>> + bool is_update = false;
>> +
>> mutex_lock(&splash_global.data_lock);
>>
>> - if (!is_fb_compatible(info))
>> - goto out;
>> + /* If we've painted on this FB recently, we don't have to do
>> + * the sanity checks and background drawing again.
>> + */
>
> multi-line comment style needs to be corrected in multiple places (in
> several of the patches).

Sorry, I'll fix that. Thanks.


Max