Re: [PATCH v2 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute

[Chanwoo Choi]

Hi Rob,

On 2017ë 10ì 25ì 23:53, Rob Herring wrote:
> On Thu, Oct 19, 2017 at 08:55:59AM +0530, Raveendra Padasalagi wrote:
>> Add documentation on optional dt attribute "debounce-timeout-ms"
>> in extcon node to capture user specified timeout value for id
>> and vbus gpio detection.
>>
>> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@xxxxxxxxxxxx>
>> Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>
>> Reviewed-by: Srinath Mannam <srinath.mannam@xxxxxxxxxxxx>
>> ---
>>
>> Changes in v2:
>>  Rename debounce-timeout-ms to input-debounce
>>
>>  Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++
>>  1 file changed, 3 insertions(+)
> 
> Sorry, but extcon bindings should be scrapped IMO and I don't want to 
> see additions. "extcon" is a Linuxism and is the first clue.

As you commented on other mailing list, compatible name had to decide
the type of connector. So, The compatible name will be changed
from 'extcon-usb-gpio' to 'gpio-usb-connectors' in order to
remove the 'extcon' from compatible name.

> 
> What's needed is a full USB connector binding, not just some incomplete 
> handling of ID and Vbus pins. There's some work happening on that[1].

These patch set[1] are related to connect/bind between provider driver
and consumer driver through OF graph.

Before, the provider driver should probe their job on the device driver.
This patch just add the debounce property of gpio during the probe time.

> 
> Rob
> 
> [1] https://www.spinics.net/lists/linux-usb/msg161106.html

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics