Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG

[Gustavo A. R. Silva]

Hi Herbert,

Quoting Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>:

> On Wed, Oct 25, 2017 at 07:38:35PM -0500, Gustavo A. R. Silva wrote:
> > I don't think we want something like:
> >
> > bool err;
> >
> > err = build_spdinfo(r_skb, net, sportid, seq, *flags) < 0 ? true : false;
> > BUG_ON(err);
>
> How about
>
> 	int err;
>
> 	err = build_spdinfo(r_skb, net, sportid, seq, *flags);
> 	BUG_ON(err < 0);

I like it.

Thanks
--
Gustavo A. R. Silva