Re: [PATCH 03/18] x86/asm/64: Move SWAPGS into the common iret-to-usermode path

From: Brian Gerst
Date: Thu Oct 26 2017 - 09:52:48 EST


On Thu, Oct 26, 2017 at 4:26 AM, Andy Lutomirski <luto@xxxxxxxxxx> wrote:
> All of the code paths that ended up doing IRET to usermode did
> SWAPGS immediately beforehand. Move the SWAPGS into the common
> code.
>
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>

> +GLOBAL(swapgs_restore_regs_and_return_to_usermode)

Is adding swapgs to the label really necessary? It's redundant with
the usermode part. I'm noticing a trend towards absurdly verbose
labels lately.

--
Brian Gerst