Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

From: Bart Van Assche
Date: Thu Oct 26 2017 - 10:04:26 EST


On Thu, 2017-10-26 at 10:24 +0200, Kees Cook wrote:
> On Wed, Oct 25, 2017 at 5:03 PM, Bart Van Assche <Bart.VanAssche@xxxxxxx> wrote:
> > On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote:
> > > However, maintainers: sorry to send this one -- it can't be merged
> > > yet, this uses timer_setup_on_stack() which is only in -next right
> > > now. If it looks okay, though, I can carry this in the timer tree.
> >
> > Hello Kees,
> >
> > Can you have a look at the following patch and queue it before your
> > patch if you think this would be useful (this patch has been tested):
> > "target/iscsi: Simplify timer manipulation code"
> > (https://www.spinics.net/lists/target-devel/msg15385.html).
>
> This looks good, yeah. Can you resend it with me CCed? It doesn't look
> like it was CCed to lkml, so it's not easy to for me to add it to me
> tree.

OK, I will resend that patch as a reply to this e-mail. BTW, I just finished
retesting that patch on top of v4.14-rc6.

Bart.