Re: [PATCH v2] i2c: aspeed: Deassert reset in probe

[Wolfram Sang]

> > +       bus->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
> 
> This could return error values in case of broken device trees, so you
> may want to check IS_ERR(bus->rst) and handle the error here.
> 
> > +       reset_control_deassert(bus->rst);
> 
> Otherwise this will dump a warning.
> 
> > +
> >         ret = of_property_read_u32(pdev->dev.of_node,
> >                                    "bus-frequency", &bus->bus_frequency);
> >         if (ret < 0) {
> > @@ -919,6 +925,8 @@ static int aspeed_i2c_remove_bus(struct platform_device *pdev)
> >
> >         i2c_del_adapter(&bus->adap);
> >
> > +       reset_control_assert(bus->rst);
> 
> As will this.
> 
> Reviewed-by: Philipp Zabel <philipp.zabel@xxxxxxxxx>

Joel, do you want to fix it? I'd think it makes sense...

Attachment: signature.asc
Description: PGP signature