Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init()

From: Ingo Molnar
Date: Fri Oct 27 2017 - 04:43:22 EST



* Juergen Gross <jgross@xxxxxxxx> wrote:

> Don't try to set the static virt_spin_lock_key to a value before
> jump_label_init() has been called, as this will result in a WARN().
>
> Solve the problem by introducing a new lock_init() hook called after
> jump_label_init() instead of doing the call inside of
> smp_prepare_boot_cpu().
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> Based on kernel/git/tip/tip.git locking/core

Just a quick ping: what's the conclusion of the discussion, do we want this patch
as-is?

Also, it's unclear from the changelog under what circumstances this bug was
observed and what symptoms there are and how severe the bug - can the warning
trigger on vanilla v4.14?

Thanks,

Ingo