Re: [PATCH 5/9] staging: lustre: ldlm: remove unused 'overlaps' variable

[Dilger, Andreas]

On Oct 22, 2017, at 18:53, NeilBrown <neilb@xxxxxxxx> wrote:
> 
> 'overlaps' is never used, only incremented.
> 
> Signed-off-by: NeilBrown <neilb@xxxxxxxx>

Reviewed-by: Andreas Dilger <andreas.dilger@xxxxxxxxx>

> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |    3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
> index 2d1fa2b33129..d5a5742a1171 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
> @@ -133,7 +133,6 @@ static int ldlm_process_flock_lock(struct ldlm_lock *req)
> 	struct ldlm_lock *new2 = NULL;
> 	enum ldlm_mode mode = req->l_req_mode;
> 	int added = (mode == LCK_NL);
> -	int overlaps = 0;
> 	int splitted = 0;
> 	const struct ldlm_callback_suite null_cbs = { };
> 
> @@ -226,8 +225,6 @@ static int ldlm_process_flock_lock(struct ldlm_lock *req)
> 		    lock->l_policy_data.l_flock.start)
> 			break;
> 
> -		++overlaps;
> -
> 		if (new->l_policy_data.l_flock.start <=
> 		    lock->l_policy_data.l_flock.start) {
> 			if (new->l_policy_data.l_flock.end <
> 
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation