Re: [PATCH 1/4] m68k/mac: More printk modernization

[Kars de Jong]

2017-10-27 4:45 GMT+02:00 Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>:
> Log message fragments used to be printed on one line but now get split up.
> Fix this. Also, suppress log spam that merely prints known pointer values.
>
> Tested-by: Stan Johnson <userm57@xxxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
> ---
>  arch/m68k/mac/baboon.c |  2 +-
>  arch/m68k/mac/iop.c    |  4 ++--
>  arch/m68k/mac/psc.c    |  6 ++----
>  arch/m68k/mac/via.c    | 18 +++++-------------
>  4 files changed, 10 insertions(+), 20 deletions(-)

...

> diff --git a/arch/m68k/mac/psc.c b/arch/m68k/mac/psc.c
> index 439a2a2e5874..8d547df4e16c 100644
> --- a/arch/m68k/mac/psc.c
> +++ b/arch/m68k/mac/psc.c
> @@ -42,7 +42,7 @@ static void psc_debug_dump(void)
>                 return;
>
>         for (i = 0x30 ; i < 0x70 ; i += 0x10) {
> -               printk("PSC #%d:  IFR = 0x%02X IER = 0x%02X\n",
> +               printk(KERN_DEBUG "PSC #%d:  IFR = 0x%02X IER = 0x%02X\n",
>                         i >> 4,
>                         (int) psc_read_byte(pIFRbase + i),
>                         (int) psc_read_byte(pIERbase + i));

Any particular reason why you didn't use pr_debug() here? I'm guessing
it's because this is not a known pointer value?

Kars.