Re: [RFC 08/14] bootsplash: Add file reading and picture rendering

[Max Staudt]

On 10/25/2017 10:27 PM, Takashi Iwai wrote:
> On Wed, 25 Oct 2017 19:32:53 +0200,
> Randy Dunlap wrote:
>>
>> On 10/25/17 05:45, Max Staudt wrote:
>>
>>> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
>>> index a6617c07229a..c3496c5ac2bb 100644
>>> --- a/drivers/video/console/Kconfig
>>> +++ b/drivers/video/console/Kconfig
>>> @@ -175,6 +175,14 @@ config BOOTSPLASH
>>>            If unsure, say N.
>>>            This is typically used by distributors and system integrators.
>>>  
>>> +config BOOTSPLASH_FILE
>>> +        string "Default full path to bootsplash file"
>>> +        depends on BOOTSPLASH
>>> +        default "/bootsplash"
>>> +        help
>>> +          This file will be looked for in the initramfs and, if found, loaded
>>> +          and used as a bootsplash.
>>
>>
>> Some people try to avoid using initramfs.
>>
>> Can one have a bootsplash without initramfs?
> 
> The current code is apparently not capable, but it shouldn't be too
> difficult to re-use the built-in firmware.  i.e. essentially copying
> fw_get_builtin_firmware() in drivers/base/firmware_class.c.
> 
> Also the bootsplash can appear after mounting the rootfs, too.  Before
> that, it's simply a blank screen.  So it's not entirely useless even
> without initrd / initramfs.

Good point, I'll look into this.


Thanks

Max