Re: [PATCH] staging: ccree: Fix indentation in ssi_buffer_mgr.c
From: Joe Perches
Date: Fri Oct 27 2017 - 10:24:07 EST
On Fri, 2017-10-27 at 11:32 +0300, Dan Carpenter wrote:
> On Thu, Oct 26, 2017 at 06:53:42PM -0700, Stephen Brennan wrote:
> > In particular, fixes some over-indented if statement bodies as well as a
> > couple lines indented with spaces. checkpatch.pl now reports no warnings
> > on this file other than 80 character warnings.
[]
> > diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c
[]
> > @@ -1029,10 +1029,10 @@ static inline int ssi_buffer_mgr_prepare_aead_data_mlli(
> > * verification is made by CPU compare in order to simplify
> > * MAC verification upon request completion
> > */
> > - u32 size_to_skip = req->assoclen;
> > + u32 size_to_skip = req->assoclen;
> >
> > - if (areq_ctx->is_gcm4543)
> > - size_to_skip += crypto_aead_ivsize(tfm);
> > + if (areq_ctx->is_gcm4543)
> > + size_to_skip += crypto_aead_ivsize(tfm);
> >
> > ssi_buffer_mgr_copy_scatterlist_portion(
> > dev, areq_ctx->backup_mac, req->src,
>
> But then ssi_buffer_mgr_copy_scatterlist_portion() is still not indented
> correctly.
The latest version of checkpatch should bleat something on the
...scatterlist_portion(
line