Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed

[Moni Shoua]

On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer
<tbogendoerfer@xxxxxxx> wrote:
> Following crash happens, if crc algorithm couldn't be allocated:
>
> [ 1087.989072] rdma_rxe: loaded
> [ 1097.855397] PCLMULQDQ-NI instructions are not detected.
> [ 1097.901220] rdma_rxe: failed to allocate crc algorithmi err:-2
> [ 1097.901248] BUG: unable to handle kernel
> [ 1097.901249] NULL pointer dereference
> [ 1097.901250]  at 0000000000000046
> [...]
>
> Reason is that rxe->tfm is assigned the error return, which will then
> be used for crypto_free_shash() in rxe_cleanup. Fix by using a
> temporay variable and assigning it rxe->tfm after allocation succeeded.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@xxxxxxx>
Fix looks good only a Fixes line is missing from the commit message. Please add.