Re: [PATCH] staging: greybus: spilib: fix use-after-free after deregistration

[Johan Hovold]

On Sun, Oct 29, 2017 at 06:13:28PM +0530, Viresh Kumar wrote:
> On 29-10-17, 13:01, Johan Hovold wrote:
> > Remove erroneous spi_master_put() after controller deregistration which
> > would access the already freed spi controller.
> > 
> > Note that spi_unregister_master() drops our only controller reference.
> > 
> > Fixes: ba3e67001b42 ("greybus: SPI: convert to a gpbridge driver")
> > Cc: stable <stable@xxxxxxxxxxxxxxx>     # 4.9
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> 
> While looking at this I think I found another problem (I will send it as a
> separate patch later on) and this fixes it:

That's right, and I already posted a fix for that use-after-free:

	https://lkml.kernel.org/r/20171029115625.32385-1-johan@xxxxxxxxxx

Thanks,
Johan