Re: [PATCH stable-4.1.y] tools include: Add a __fallthrough statement
From: Levin, Alexander (Sasha Levin)
Date: Sun Oct 29 2017 - 23:04:39 EST
On Fri, Oct 27, 2017 at 12:05:58PM -0700, Florian Fainelli wrote:
>From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
>commit b5bf1733d6a391c4e90ea8f8468d83023be74a2a upstream.
>
>For cases where implicit fall through case labels are intended,
>to let us inform that to gcc >= 7:
>
> CC /tmp/build/perf/util/string.o
> util/string.c: In function 'perf_atoll':
> util/string.c:22:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
> if (*p)
> ^
> util/string.c:24:3: note: here
> case '\0':
> ^~~~
>
>So we introduce:
>
> #define __fallthrough __attribute__ ((fallthrough))
>
>And use it in such cases.
Queued up, thanks!
--
Thanks,
Sasha