Re: [PATCH V4 07/12] boot_constraint: Add debugfs support
From: Randy Dunlap
Date: Sun Oct 29 2017 - 23:43:51 EST
On 10/29/17 20:37, Viresh Kumar wrote:
> On 29-10-17, 08:09, Randy Dunlap wrote:
>> On 10/29/17 06:48, Viresh Kumar wrote:
>>> This patch adds debugfs support for boot constraints. This is how it
>>> looks for a "vmmc-supply" constraint for the MMC device.
>>>
>>> Tested-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
>>> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>>> ---
>>> drivers/boot_constraints/clk.c | 3 ++
>>> drivers/boot_constraints/core.c | 60 +++++++++++++++++++++++++++++++++++++++
>>> drivers/boot_constraints/core.h | 6 ++++
>>> drivers/boot_constraints/pm.c | 11 +++++--
>>> drivers/boot_constraints/supply.c | 9 ++++++
>>> 5 files changed, 87 insertions(+), 2 deletions(-)
>>
>> Hi,
>> Does this build OK when CONFIG_DEBUG_FS is not enabled?
>>
>> I didn't see any depends on or select DEBUG_FS or any use of
>> CONFIG_DEBUG_FS in any Makefile.
>
> As soon as I saw your reply, it looked like I have seen this email
> earlier. :)
>
> https://marc.info/?l=linux-kernel&m=149866480929111&w=2
>
> And yes, it builds just fine as all the dummy helpers are in place.
>
Thanks.
--
~Randy