Re: [PATCH] hw_random: Include device.h instead of declaring struct device

From: Herbert Xu
Date: Mon Oct 30 2017 - 02:52:48 EST


On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote:
> Include linux/device.h instead of declaring struct device.
>
> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx>

Nack. We should not include a header file when a simple forward
declaration is enough.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt