Re: net: hns: set correct return value
From: Tobias Klauser
Date: Mon Oct 30 2017 - 04:18:03 EST
On 2017-10-29 at 15:35:32 +0100, Pan Bian <bianpan2016@xxxxxxx> wrote:
> The function of_parse_phandle() returns a NULL pointer if it cannot
> resolve a phandle property to a device_node pointer. In function
> hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract
> the error code. However, in this case, the extracted error code will
> always be zero, which is unexpected.
>
> Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>
The subject is missing a [PATCH] prefix which causes the patch e.g. to
not show up on patchwork [1]. Care to resend with the proper subject?
[1] https://patchwork.ozlabs.org/project/netdev/list/
Care to resend with the proper subject?
For the patch itself:
Reviewed-by: Tobias Klauser <tklauser@xxxxxxxxxx>