Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

[Andy Shevchenko]

On Sun, Oct 29, 2017 at 11:28 PM, MichaÅ KÄpieÅ <kernel@xxxxxxxxxx> wrote:
>> On Wed, Oct 25, 2017 at 7:29 AM, MichaÅ KÄpieÅ <kernel@xxxxxxxxxx> wrote:
>> > Radio LED detection method implemented in commit 4f62568c1fcf
>> > ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it
>> > causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751
>> > which has a slide switch (and thus no radio LED).  Use bit 17 of
>> > flags_supported (the value returned by method S000 of ACPI device
>> > FUJ02E3) to determine whether a radio LED is present as it seems to be a
>> > more reliable indicator, based on comparing DSDT tables of four Fujitsu
>> > Lifebook models (E744, E751, S7110, S8420).
>> >
>>
>> Pushed to my review and testing queue, thanks!
>
> I forgot that this patch can also be tagged with:
>
> Fixes: 4f62568c1fcf ("fujitsu-laptop: Support radio LED")

Added.

Do you consider this an important fix? We are at -rc7 now, I'm not
sure it's so critical. Tell me if you consider otherwise.

-- 
With Best Regards,
Andy Shevchenko