Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

[Liang C]

Hi Michael,
Would you please to include this patch in your tree for the next
release? It seems passed the review. Thank you.

Thanks,
Liang

On Tue, Oct 10, 2017 at 11:44 PM, Michael Lyle <mlyle@xxxxxxxx> wrote:
> On 10/10/2017 05:25 AM, Coly Li wrote:
>> On 2017/10/10 äå5:00, Liang Chen wrote:
>>> mutex_destroy does nothing most of time, but it's better to call
>>> it to make the code future proof and it also has some meaning
>>> for like mutex debug.
>>>
>>> As Coly pointed out in a previous review, bcache_exit() may not be
>>> able to handle all the references properly if userspace registers
>>> cache and backing devices right before bch_debug_init runs and
>>> bch_debug_init failes later. So not exposing userspace interface
>>> until everything is ready to avoid that issue.
>>>
>>> Signed-off-by: Liang Chen <liangchen.linux@xxxxxxxxx>
>>
>> Hi Liang,
>>
>> No more comment from me, it looks good. Thanks.
>>
>> Reviewed-by: Coly Li <colyli@xxxxxxx>
>
> Looks good to me too.
>
> Reviewed-by: Michael Lyle <mlyle@xxxxxxxx>
>