Re: [PATCH v3] i2c: aspeed: Deassert reset in probe

[Wolfram Sang]

>  #include <linux/clk.h>
>  #include <linux/completion.h>
> +#include <linux/delay.h>

Sorry, I missed it from previous reviews, but why is delay.h needed?

> +	bus->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
> +	if (IS_ERR(bus->rst)) {
> +		dev_err(&pdev->dev, "invalid reset controller in device tree");
> +		bus->rst = NULL;
> +	} else
> +		reset_control_deassert(bus->rst);

checkpatch --strict says:

CHECK: braces {} should be used on all arms of this statement

Attachment: signature.asc
Description: PGP signature