Re: [PATCH] ecryptfs: remove unnecessary i_version bump

[Jeff Layton]

On Mon, 2017-10-30 at 11:01 -0400, Jeff Layton wrote:
> From: Jeff Layton <jlayton@xxxxxxxxxx>
> 
> There is no need to bump the i_version counter here, as ecryptfs does
> not set the MS_I_VERSION flag, and doesn't use it internally. It also

My apologies, I've been sitting on this patch for a while now. That
should be changed to the SB_I_VERSION flag. Tyler, do you mind fixing
that up before merge, or would you like me to resend?

> only bumps it when the inode is instantiated, which doesn't make much
> sense.
> 
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
>  fs/ecryptfs/inode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
> index efc2db42d175..b59b083379ea 100644
> --- a/fs/ecryptfs/inode.c
> +++ b/fs/ecryptfs/inode.c
> @@ -64,7 +64,6 @@ static int ecryptfs_inode_set(struct inode *inode, void *opaque)
>  	/* i_size will be overwritten for encrypted regular files */
>  	fsstack_copy_inode_size(inode, lower_inode);
>  	inode->i_ino = lower_inode->i_ino;
> -	inode->i_version++;
>  	inode->i_mapping->a_ops = &ecryptfs_aops;
>  
>  	if (S_ISLNK(inode->i_mode))

-- 
Jeff Layton <jlayton@xxxxxxxxxxxxxxx>